Skip to content

Replace dependency passport-saml with @node-saml/passport-saml ^4.0.4#12489

Open
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/passport-saml-replacement
Open

Replace dependency passport-saml with @node-saml/passport-saml ^4.0.4#12489
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/passport-saml-replacement

Conversation

@renovate
Copy link
Copy Markdown

@renovate renovate Bot commented Apr 28, 2026

This PR contains the following updates:

Package Type Update Change
passport-saml@node-saml/passport-saml dependencies replacement ^3.1.2^4.0.4

This is a special PR that replaces passport-saml with the community suggested minimal stable replacement version.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate Bot added the dependencies Pull requests that update a dependency file label Apr 28, 2026
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Apr 28, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@github-actions github-actions Bot added the auth label Apr 28, 2026
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Apr 28, 2026

🤖 Augment PR Summary

Summary: This PR replaces the SAML Passport strategy dependency used by the auth-backend plugin.

Changes:

  • Swaps passport-saml for the community-maintained scoped package @node-saml/passport-saml at ^4.0.4.
  • Updates the lockfile to reflect the dependency replacement.

Why: Renovate-generated “replacement” update to move off the legacy passport-saml package and onto the suggested successor.

Technical Notes: Any runtime/TS imports that still reference passport-saml (including deep type imports) may need to be updated to the new package name.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

"passport-oauth2": "^1.6.1",
"passport-onelogin-oauth": "^0.0.1",
"passport-saml": "^3.1.2",
"@node-saml/passport-saml": "^4.0.4",
Copy link
Copy Markdown

@augmentcode augmentcode Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugins/auth-backend/src/providers/saml/provider.ts still imports from passport-saml (and passport-saml/lib/...), so switching the dependency to @node-saml/passport-saml will likely cause module resolution failures at build/runtime unless those import paths are updated too.

Severity: high

Other Locations
  • plugins/auth-backend/src/providers/saml/provider.ts:18
  • plugins/auth-backend/src/providers/saml/provider.ts:23

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

EntelligenceAI PR Summary

Migrates SAML authentication library from deprecated passport-saml to @node-saml/passport-saml v4.0.4 in the auth-backend plugin, with corresponding lockfile updates.

  • plugins/auth-backend/package.json: Swaps passport-saml@^3.1.2 for @node-saml/passport-saml@^4.0.4
  • yarn.lock: Removes passport-saml resolution, adds @node-saml/passport-saml and its transitive dependencies (@node-saml/node-saml, upgraded xml-crypto, xml-encryption, xml2js, @xmldom/xmldom)
  • yarn.lock: Pins @backstage/plugin-gitops-profiles workspace dependencies to fixed npm versions (config@0.1.1, core-components@0.1.0, core-plugin-api@0.1.0, theme@0.1.1, version-bridge@0.1.0)
  • yarn.lock: Introduces additional transitive dependencies including cross-fetch, node-fetch, core-js, dompurify, react-syntax-highlighter, updated @types/express and @types/passport, and legacy remark/micromark packages

Confidence Score: 4/5 - Mostly Safe

Likely safe but review recommended — this PR correctly migrates passport-saml@^3.1.2 to @node-saml/passport-saml@^4.0.4, which is the actively maintained fork of the deprecated library and a well-known community-recommended upgrade path. The change is scoped to plugins/auth-backend/package.json and yarn.lock, with no application logic modified. However, this is a major version bump (v3 → v4) of a security-critical authentication library, and the PR summary does not mention any validation of API compatibility or testing of SAML login flows, which warrants at least a functional verification before merging.

Key Findings:

  • The migration from passport-saml to @node-saml/passport-saml is the correct community-endorsed upgrade path for this deprecated package, and the target version ^4.0.4 includes security fixes for XML parsing vulnerabilities via upgraded xml-crypto, xml-encryption, and @xmldom/xmldom dependencies.
  • This is a major version bump (v3 → v4) of a SAML authentication library — v4 introduced breaking changes in configuration options and strategy initialization (e.g., issuer moved, cert handling changed) — no evidence in the PR that auth-backend's SAML strategy implementation was audited for compatibility with the new API surface.
  • The transitive dependency tree changes are substantial (new @node-saml/node-saml package, upgraded xml2js, xmldom), and while these are generally improvements, the yarn.lock changes were not reviewed by the automated analysis, leaving some uncertainty about whether all resolved versions are consistent.
  • No test evidence or CI results are referenced in the PR to confirm that SAML login/logout flows function correctly end-to-end with the new library version.
Files requiring special attention
  • plugins/auth-backend/package.json
  • yarn.lock

@socket-security
Copy link
Copy Markdown

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: Node-SAML SAML Signature Verification Vulnerability in npm @node-saml/node-saml

CVE: GHSA-4mxg-3p6v-xgq3 Node-SAML SAML Signature Verification Vulnerability (CRITICAL)

Affected versions: < 5.1.0

Patched version: 5.1.0

From: ?npm/@node-saml/passport-saml@4.0.4npm/@node-saml/node-saml@4.0.5

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@node-saml/node-saml@4.0.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
Critical CVE: Node-SAML SAML Authentication Bypass in npm @node-saml/node-saml

CVE: GHSA-m837-g268-mmv7 Node-SAML SAML Authentication Bypass (CRITICAL)

Affected versions: < 5.1.0

Patched version: 5.1.0

From: ?npm/@node-saml/passport-saml@4.0.4npm/@node-saml/node-saml@4.0.5

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@node-saml/node-saml@4.0.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
Critical CVE: Node-SAML SAML Signature Verification Vulnerability in npm @node-saml/passport-saml

CVE: GHSA-4mxg-3p6v-xgq3 Node-SAML SAML Signature Verification Vulnerability (CRITICAL)

Affected versions: < 5.1.0

Patched version: 5.1.0

From: plugins/auth-backend/package.jsonnpm/@node-saml/passport-saml@4.0.4

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@node-saml/passport-saml@4.0.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
License policy violation: npm typescript under W3C-20150513

License: W3C-20150513 - The applicable license policy does not permit this license (5) (package/ThirdPartyNoticeText.txt)

License: LicenseRef-W3C-Community-Final-Specification-Agreement - The applicable license policy does not permit this license (5) (package/ThirdPartyNoticeText.txt)

License: MIT-Khronos-old - The applicable license policy does not permit this license (5) (package/ThirdPartyNoticeText.txt)

License: CC-BY-4.0 - The applicable license policy does not permit this license (5) (package/ThirdPartyNoticeText.txt)

From: ?npm/@microsoft/api-extractor@7.33.7npm/typescript@4.8.4

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/typescript@4.8.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants